Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade seal0 calls to seal1 #1053

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 26, 2021

Closes #879.

Uses the seal1 API from https://github.com/paritytech/substrate/blob/master/frame/contracts/src/wasm/runtime.rs.

The only thing that changed is no longer passing the len for some of the pointers.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #1053 (f2c62ff) into master (fb86286) will decrease coverage by 14.77%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1053       +/-   ##
===========================================
- Coverage   78.78%   64.01%   -14.78%     
===========================================
  Files         248      248               
  Lines        9363     9361        -2     
===========================================
- Hits         7377     5992     -1385     
- Misses       1986     3369     +1383     
Impacted Files Coverage Δ
crates/lang/codegen/src/traits.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/env.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/enforced_error.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/blake2b.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/storage.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/arg_list.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/lang/codegen/src/generator/selector.rs 0.00% <0.00%> (-100.00%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb86286...f2c62ff. Read the comment docs.

@paritytech-ci
Copy link

paritytech-ci commented Nov 26, 2021

🦑 📈 ink! Example Contracts ‒ Size Change Report 📉 🦑

These are the results of building the examples/* contracts from this branch with cargo-contract 0.16.0:

Δ Original Size Δ Optimized Size Total Optimized Size
accumulator 6.13 K
adder 7.36 K
contract-terminate -0.00 K -0.00 K 1.50 K
contract-transfer 7.91 K
delegator -0.16 K -0.09 K 9.95 K
dns 21.72 K
erc1155 47.55 K
erc20 10.28 K
erc721 36.22 K
flipper 2.02 K
incrementer 1.94 K
multisig 46.16 K
proxy 3.90 K
rand-extension 5.14 K
subber 7.37 K
trait-erc20 27.52 K
trait-flipper 1.83 K
trait-incrementer 1.93 K

Link to the run | Last update: Fri Nov 26 10:27:51 CET 2021

@cmichi cmichi merged commit 141673b into master Nov 26, 2021
@cmichi cmichi deleted the cmichi-upgrade-seal0-calls-to-seal1 branch November 26, 2021 09:28
xgreenx pushed a commit to Supercolony-net/ink that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update seal0 calls to seal1
4 participants